Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3073 escaping in strings #3082

Merged
merged 3 commits into from Oct 25, 2023
Merged

Fix/3073 escaping in strings #3082

merged 3 commits into from Oct 25, 2023

Conversation

josdejong
Copy link
Owner

See #3073 (comment)

This PR:

  • Fix: function format not escaping control characters and double quotes
  • Refactor: unifies parsing of single quoted and double quoted strings internally.
  • Refactor: change parsing of strings (internally) to not rely on JSON.parse

(maybe easiest to look at the individual commits)

@josdejong josdejong mentioned this pull request Oct 18, 2023
Closed
@josdejong josdejong merged commit d1c4a56 into develop Oct 25, 2023
10 checks passed
@josdejong josdejong deleted the fix/3073-escaping-in-strings branch October 26, 2023 08:55
@pjanik pjanik mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@josdejong