Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languages #3

Closed
shanduoduo opened this issue Jul 2, 2023 · 19 comments
Closed

languages #3

shanduoduo opened this issue Jul 2, 2023 · 19 comments

Comments

@shanduoduo
Copy link

Can other languages ​​be recognized?

@josdemmers
Copy link
Owner

Yes will work for all languages. You will however need to create your own system preset.
That is needed to match your resolution and language.
See the wiki on how to get started:
https://github.com/josdemmers/Diablo4Companion/wiki/How-to-create-a-new-System-Preset

You can share your system preset afterwards with me so others can use it as well.

@shanduoduo
Copy link
Author

Does it support 4k resolution? i failed the test

@josdemmers
Copy link
Owner

josdemmers commented Jul 2, 2023

The default images are for 2560x1440 only. But if you create your own for 4k it should work.
I don't have a 4K monitor myself so can't really help you with this one.

I would suggest to start with these three images:
image
And then open the debug view and verify if you see the red outline.
image

When you have that working you can continue with the other images

@shanduoduo
Copy link
Author

image I can't see anything in this interface

@josdemmers
Copy link
Owner

You need to enable the overlay first, looks like it's still paused.
image

@shanduoduo
Copy link
Author

image The device can be identified, but the range in the red frame seems to be wrong. .

@josdemmers
Copy link
Owner

That is too bad. I'll need to fix that first.
When a new version is ready I'll let you know.
Maybe this evening but probably tomorrow.

@shanduoduo
Copy link
Author

image A bug, I try to test and identify an entry, it will show red and green at the same time, and it is very slow

@shanduoduo
Copy link
Author

image It takes about 1~2 seconds for the time marker to appear or disappear

@josdemmers
Copy link
Owner

Ok good, you got it working with another resolution.

Regarding the bugs. The app works by comparing images to find the best match. This is not very fast unfortunately. But I'm still working on improving this.

The red/green overlap could happen when two affixes look similar.

@shanduoduo
Copy link
Author

Hi,josdemmers
I can't open the program today after adding the affixes

@shanduoduo
Copy link
Author

Oh, I see, a png I tested before was deleted by me, and the config remembered the non-existing png, so it couldn’t be opened

@shanduoduo
Copy link
Author

1.Gear Affix Presets will not record the last selection
2. After opening Affix Overlay, there is a chance that the system will blue screen of death and restart

@josdemmers
Copy link
Owner

Oh, I see, a png I tested before was deleted by me, and the config remembered the non-existing png, so it couldn’t be opened

Will add a check for that.

1.Gear Affix Presets will not record the last selection 2. After opening Affix Overlay, there is a chance that the system will blue screen of death and restart

  1. Not sure what you mean by this?
  2. Never had any issues like this. Any extra info in the log file?

@josdemmers
Copy link
Owner

Release v1.1.0.0 is now ready, let me know if this solves your issue.

The wiki on how to create your own system preset is also updated:
https://github.com/josdemmers/Diablo4Companion/wiki/How-to-create-a-new-System-Preset

@josdemmers
Copy link
Owner

There is now a download manager available for the system presets. If you have a working Chinese preset you can send it to me and I'll add it to the download manager.

@shanduoduo
Copy link
Author

Ok, so far I only have one class preset

@josdemmers
Copy link
Owner

josdemmers commented Jul 9, 2023

No problem, that will already make it easier for others to get started.
Could you follow this naming format?
https://github.com/josdemmers/Diablo4Companion/wiki/How-to-create-a-new-System-Preset#naming-convention

Will need to following information to describe your configuration:
image

  • Resolution
  • HDR setting, is this on or off?
  • Font: small, medium, or large
  • Language: Chinese (Simplified) zh-CN? or Chinese (Traditional) zh-CHT?
  • Tooltip width: Can be set in debug view.

Let me know if you have any questions.

@josdemmers
Copy link
Owner

Closing this issue. When you are ready to share your system preset let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants