Improve SyntaxLogicalInverter to Handling Additional Cases and reduce Unnecesarry Parentheses #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josefpihrt
requested changes
May 18, 2023
src/Tests/CSharp.Workspaces.Tests/SyntaxLogicalInverterTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Josef Pihrt <josef@pihrt.net>
josefpihrt
approved these changes
Jun 1, 2023
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
… Unnecessary Parentheses (dotnet#1086) Co-authored-by: Josef Pihrt <josef@pihrt.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SyntaxLogicalInverter to handle a couple of new cases (NumericLiteralExpression, and StringLiteralExpression) - these were previously failing if running in debug mode e.g. causing errors in RCS1208.
Other changes of note: