Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCS1016 result doesn't compile fix #1090

Merged
merged 2 commits into from Jun 1, 2023

Conversation

jamesHargreaves12
Copy link
Contributor

If there is a trailing comment after an arrow expression then applying RCS1016 will produce code that fails to compile as the trailing '}' will be appended to the comment.

For example:

string P => null; // some comment

becomes:

string P { 
    get { return null;// some comment}
}

The cause is that the WhitespaceRemover is removing newlines even if they are preceded by a comment.

@josefpihrt josefpihrt merged commit 26e2b83 into dotnet:main Jun 1, 2023
Haarmees pushed a commit to Haarmees/Roslynator that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants