Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add support for dotnet8 #1251

Merged
merged 19 commits into from Nov 20, 2023
Merged

Feat/add support for dotnet8 #1251

merged 19 commits into from Nov 20, 2023

Conversation

JonasSchubert
Copy link
Contributor

fixes #1250

@JonasSchubert
Copy link
Contributor Author

@dotnet-policy-service agree

@josefpihrt
Copy link
Collaborator

Blocked by actions/runner-images#8819

josefpihrt
josefpihrt requested changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@josefpihrt josefpihrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for the PR, looks good, just please update changelog.

@JonasSchubert
Copy link
Contributor Author

Hi,

Thanks for the PR, looks good, just please update changelog.

Hi @josefpihrt,
Thanks for the quick workflow update. I added a note to the changelog as requested.

josefpihrt
josefpihrt previously approved these changes Nov 20, 2023
View reviewed changes
@josefpihrt josefpihrt merged commit 13c1810 into dotnet:main Nov 20, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefpihrt josefpihrt josefpihrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CLI] - Add support for .NET 8
2 participants
@JonasSchubert @josefpihrt