#323 RabbitMQ transport is sending events too slow #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 7, 2015 16:21
…er transports in debug mode in order to find problem in transport rate.
…onsumers by creating additional processes.
| @@ -53,7 +53,8 @@ def __init__(self, beaver_config, queue_consumer_function, callback, logger=None | |||
| self._folder = self._beaver_config.get('path') | |||
| self._last_file_mapping_update = {} | |||
| self._logger = logger | |||
| self._proc = None | |||
| self._number_of_consumer_processes = int(self._beaver_config.get('number_of_consumer_processes')) | |||
There was a problem hiding this comment.
All this logic should also be set in the tail_manager and tail module.
There was a problem hiding this comment.
@josegonzalez
Thanks, missed it.
I added it to worker/tail_manager.py but I don't see anything related in worker/tail.py. Can you focus on where should I add the change in worker/tail.py?
…onsumers by creating additional processes while running with --experimental flag
|
@josegonzalez I verified that the changes in the last commit are working well on my machine also with the --experimental flag but I see that the "Travis CI Build" is failing with "No output has been received in the last 10 minutes" - Is there a problem in the code or it is a problem with the test? |
added 4 commits
July 22, 2015 11:07
…nnection instead of BlockingConnection for better performance.
1. Add clear debug prints with queue size (one print every 1000 items in order not to hurt performance) 2. If main queue is empty keep running and do nothing 3. In case of a timeout from main queue restart queue
…function to print connection errors.
josegonzalez
added a commit
that referenced
this pull request
Jul 27, 2015
#323 RabbitMQ transport is sending events too slow
|
Fixes #265 |
|
Fixes #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix includes two part:
Please let me know if you have any questions or remarks - from the tests I ran in my environment using the rabbitMQ trasport (sends around 6500 log entries per second), increasing the number of consumers really helped.