transports/rabbitmq: add timeout option (updated)

[timstoop]

This is a duplicate of pull request #253, but updated to be mergable with master again. It adds a timeout option to rabbitmq, since pika defaults to .25 seconds, which can lead to problems when a lot of clients are connecting at the same time.

This solves a practical problem for us, where hundreds of clients can simply overwhelm a rabbitmq server at connection time, so it cannot respond within the .25 seconds. This patch increases the timeout to 2 seconds, which solves the problem for us. It also makes it a setting.

[kitchen]

My vote: leave the default but make it configurable.

-Jeremy

Insert PGP signature here.

On Sep 10, 2015, at 9:22 AM, Tim Stoop notifications@github.com wrote:

This is a duplicate of pull request #253, but updated to be mergable with master again. It adds a timeout option to rabbitmq, since pika defaults to .25 seconds, which can lead to problems when a lot of clients are connecting at the same time.

This solves a practical problem for us, where hundreds of clients can simply overwhelm a rabbitmq server at connection time, so it cannot respond within the .25 seconds. This patch increases the timeout to 2 seconds, which solves the problem for us. It also makes it a setting.

You can view, comment on, or merge this pull request online at:

#345

Commit Summary

Pieter's patch for rabbitmq timeout.
File Changes

M beaver/config.py (2)
M beaver/transports/rabbitmq_transport.py (5)
M docs/user/usage.rst (1)
Patch Links:

https://github.com/josegonzalez/python-beaver/pull/345.patch
https://github.com/josegonzalez/python-beaver/pull/345.diff
—
Reply to this email directly or view it on GitHub.

[josegonzalez]

Can you look into the failing tests? I'll buy you a beer :) (or hot chocolate, if that's your thing).

[timstoop]

Settings need to be integers, apparently. So instead of trying to change that, I decided on a middle ground with a 1 second default. Hope that alright?

And beer is totally great! However, credit should go to @pieterlexis, who actually created the patch. I only made it apply again.