Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--pull-details not working: TypeError #115

Closed
mibe opened this issue Jun 9, 2019 · 5 comments
Closed

--pull-details not working: TypeError #115

mibe opened this issue Jun 9, 2019 · 5 comments

Comments

@mibe
Copy link

mibe commented Jun 9, 2019

I'm getting a TypeError error when backing up my repos, specifically the comments to a pull request.

Here are the last relevant lines:

Saving 23 pull requests to disk
Requesting https://api.github.com/repos/mibe/FeedWriter/pulls/1/comments?page=1&per_page=100
Traceback (most recent call last):
  File "/usr/local/bin/github-backup", line 1035, in <module>
    main()
  File "/usr/local/bin/github-backup", line 1030, in main
    backup_repositories(args, output_directory, repositories)
  File "/usr/local/bin/github-backup", line 691, in backup_repositories
    backup_pulls(args, repo_cwd, repository, repos_template)
  File "/usr/local/bin/github-backup", line 813, in backup_pulls
    pulls[number]['comment_data'] = retrieve_data(args, template)
TypeError: list indices must be integers or slices, not str

This was the command line:
github-backup -t $TOKEN --all --pull-details --gists -o . mibe

$ github-backup --version:
github-backup 0.23.0
$ python3 --version:
Python 3.5.3
@josegonzalez
Copy link
Owner

Pull requests welcome.

@mibe mibe changed the title TypeError: list indices must be integers or slices, not str --pull-details not working: TypeError Jun 10, 2019
@mibe
Copy link
Author

mibe commented Jun 10, 2019

It looks like this bug is specific to the --pull-details argument. The error disappears when omitting this parameter.

@whwright
Copy link
Contributor

#118

@josegonzalez
Copy link
Owner

Closing as there is a merged pull request.

@mibe
Copy link
Author

mibe commented Jun 29, 2019

I can confirm 0.24.0 does not crash when using --pull-details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants