Skip to content
This repository has been archived by the owner on Feb 18, 2023. It is now read-only.

Drop Dingo API #36

Closed
joselfonseca opened this issue Sep 13, 2017 · 3 comments
Closed

Drop Dingo API #36

joselfonseca opened this issue Sep 13, 2017 · 3 comments
Labels

Comments

@joselfonseca
Copy link
Owner

Hey @kslimani

What do you think about dropping Dingo as it is not really being maintained? Can you tell me what specific things from Dingo you are tied to or want to still see in the starter kit. Also keep in mind that we now have Resources (https://laravel.com/docs/5.5/eloquent-resources) in Laravel so we could drop Fractal as well.

Let me know what you think.

@kslimani
Copy link
Contributor

Hello @joselfonseca,

Unless Laravel 5.5 support is added to Dingo, i see no immediate alternative than dropping it. (afaik, if not dropped, upgrading starter kit to Laravel 5.5 may be tricky).

Lost features are, i think, route versioning, content negotiation and maybe api blueprint documentation (but find an api documentation alternative should not be that complex).

Personally, i am not tied to any of these features (but some people may care, especially on route versioning).

Fractal seems to be Dingo peer dependency. Dingo adds some feature like automatic model include relationship. It seems it can be reproduced with Resources using the Conditional Relationships feature. (it did not yet test myself, only read the docs).

@joselfonseca
Copy link
Owner Author

Yes, I think route versioning is what i am more tied to in Dingo, that part is just great, the problem is that Dingo has not have much activity lately and i am afraid the package may loose support soon if no one else takes it. That is my main concern.

Do you know or anyone else knows any alternatives to the Route versioning by header feature dingo provides?

Fractal is indeed required by Dingo, i was thinking more about the transformers, like changing them to use resources.

@joselfonseca
Copy link
Owner Author

Turns out Dingo is compatible with Laravel 5.5 and a new project was open to continue the support of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants