Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #140

Merged
merged 1 commit into from Sep 17, 2022
Merged

Fix typos #140

merged 1 commit into from Sep 17, 2022

Conversation

kianmeng
Copy link
Contributor

Description

Found via codespell -L crate

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Found via `codespell -L crate`
@joseluisq
Copy link
Collaborator

Nice!

BTW are you interested in adding a CI typos check? It would be great.
But I let that in your side as optional.

@joseluisq joseluisq added documentation Improvements or additions to documentation enhancement New feature or request v2 v2 release labels Sep 16, 2022
@kianmeng
Copy link
Contributor Author

kianmeng commented Sep 16, 2022

@joseluisq

Regarding https://github.com/crate-ci/typos, didn't realize Rust ecosystem has its own spelling checker! Thanks for sharing. 🥳

Do you want to add the typos check CI job in separate PR or in this PR instead?
Also, what do you think about prettify the whole repo using https://github.com/prettier/prettier?

@joseluisq
Copy link
Collaborator

Do you want to add the typos check CI job in separate PR or in this PR instead?

Sure, another PR for that is a good idea.

Also, what do you think about prettify the whole repo using https://github.com/prettier/prettier?

What essential might be prettify used for? Formatting/Linting markdown file only or?

@dlvoy
Copy link
Contributor

dlvoy commented Sep 16, 2022

I wonder if prettier won't be redundant since in pipeline there is already step for code format enforcing:
cargo fmt --all -- --check

@joseluisq
Copy link
Collaborator

Yes, prettier sounds redundant to me as well.
However, we can go with a new CI workflow for checking typos in a new PR.

@joseluisq joseluisq merged commit 59a75e6 into static-web-server:master Sep 17, 2022
@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request v2 v2 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants