HTTP redirect server #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables the possibility of launching multiple Iron server instances, which is required for implementing the redirect HTTP server.
When using TLS/SSL, it may be desired to run an additional HTTP server that redirects all requests to the TLS/SSL version of the website as a convenience for the users. This server is disabled by default and can be enabled using the tls_redirect_from option. The HTTPS host for the redirect can be set through the tls_redirect_dest option.
joseluisq
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
Everything looks ok and a 308 is also fine.
~> static-web-server --port 443 --tls true --tls-pkcs12 dev.local-identity.p12 --tls-pkcs12-passwd my_password --tls-redirect-from 80 --tls-redirect-host dev.local
# 2021-01-04T01:56:21 [SERVER] - Static HTTPS Server "my-static-server" is listening on [::]:443
# 2021-01-04T01:56:21 [SERVER] - Redirect HTTP Server "my-static-server" is listening on [::]:80~> curl -I http://dev.local
# HTTP/1.1 308 Permanent Redirect
# Location: https://dev.local/
# Content-Length: 0
# Date: Mon, 04 Jan 2021 00:56:25 GMT
|
Thanks! |
|
You're welcome! |
|
New v1.13.0 released. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a common use case that a web server that delivers content as HTTPS also supports redirecting from the HTTP protocol. This PR introduces a corresponding feature "HTTP redirect server" and contains the following changes:
This change enables the possibility of launching multiple Iron server
instances, which is required for implementing the redirect HTTP server.
When using TLS/SSL, it may be desired to run an additional HTTP server
that redirects all requests to the TLS/SSL version of the website as a
convenience for the users.
This server is disabled by default and can be enabled using the
tls_redirect_from option. The HTTPS host for the redirect can be set
through the tls_redirect_dest option.
Feel free to comment any flaws of the implementation, I'm happy to improve it.
This closes #25.