Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadFrameFromHTML doesn't work anymore #49

Closed
aronwoost opened this issue Aug 6, 2011 · 1 comment
Closed

loadFrameFromHTML doesn't work anymore #49

aronwoost opened this issue Aug 6, 2011 · 1 comment

Comments

@aronwoost
Copy link

because this line should be src = src.replace(/\n/g, '\\n').replace(/\r/, '\\r');

However, we'll also use loadFrameFromJavaScript from now on.

@joseph joseph closed this as completed in 03be688 Aug 7, 2011
@joseph
Copy link
Owner

joseph commented Aug 7, 2011

Good catch, thanks. Yep, we've moved to loadFrameFromJavaScript too, since we cache the component string in its JS-friendly form. Guess that was a careless copy/paste from the logic in Booki.sh's upper layer where we do the clean. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants