-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filenames not accepted with -p
#68
Comments
@mark-pictor-csec if you have an 80MB file, why not just use the commandline? Is there a reason you want to use the UI for that? Just want to understand your usecase better. |
Yeah I can use the commandline. I was curious what the UI offered, so used the files I had at hand. I do think it would be nice to have the option of skipping the copy and paste, regardless of file size. |
@mark-pictor-csec I've tried to make the UI as "not scary" from a security perspective as possible. None of the data that goes in goes over the network. It's all processed in the browser via jd as a library in WASM. So I would hesitate to have the browser ask for access to the filesystem. And I don't want to complicate the UI by dynamically providing files on the commandline. So I'm not going to add this for now. One thing I could do is give an error when you type |
Also |
I've added this error message: 8e742b1 It will be included in the next jd release. |
Apparently I typo'd that when creating the issue, as it tells me |
With v1.7.1:
jd -p 9999 a.json b.json
doesn't give me an error, but when I access the ui it looks like I'm expected to paste files in.My input files are ~80MB. Not sure how well osx would handle that :)
It'd be nice if the files could be passed to wasm, or at least have an upload button rather than requiring copy and paste.
The text was updated successfully, but these errors were encountered: