Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use t_float instead of float #2

Open
umlaeute opened this issue Nov 8, 2018 · 1 comment
Open

use t_float instead of float #2

umlaeute opened this issue Nov 8, 2018 · 1 comment

Comments

@umlaeute
Copy link
Contributor

umlaeute commented Nov 8, 2018

Pd is (slowly) moving towards double-precision.

as such, you should never use float or double of any numbers that communicate with Pd, as this will guarantee to break once Pd changes it's internal number representation to double precision.

instead, always use t_float for numbers and t_sample for signals.

@josephlarralde
Copy link
Owner

Got it, I'll update this.

BTW, thanks for your last PR, it seems to solve most parts of the problem.
I still need to figure out a way to deal with the .w_float needed to access the actual array values, though. I'll test your patch but I bet it will need a few more tweaks to get the object back working (and maybe some modifications to jl.cpp.lib, too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants