Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Module #15

Closed
DamagedDingo opened this issue Sep 15, 2020 · 6 comments · Fixed by #14
Closed

Update Module #15

DamagedDingo opened this issue Sep 15, 2020 · 6 comments · Fixed by #14
Assignees

Comments

@DamagedDingo
Copy link
Contributor

Hi. No idea if I have done this right but i added 2 more functions for Zoom Rooms.
List-ZoomRooms
List-ZoomRoomDevices

I want to add another but am not sure of the name to use.
https://marketplace.zoom.us/docs/api-reference/zoom-api/dashboards/dashboardzoomrooms

I will use List-DashboardZoomRooms unless someone suggests something else.

@DamagedDingo
Copy link
Contributor Author

#14
These are the 2 new functions.

@JosephMcEvoy
Copy link
Owner

JosephMcEvoy commented Sep 15, 2020

#14 Correct me if I'm wrong -- List-ZoomRooms is the same cmdlet as Get-ZoomRooms, no? Looks like Zoom updated this API. You could open up a pull request to update the existing cmdlet. Do use PowerShell approved verbs. The cmdlets mentioned should all use Get.

Looks like you you're keeping with the style of the project (much appreciated). Something that is inconsistent across PSZoom's cmdlets is variable capitalization. Parameters should be capitalized while everything else should be camel case. Just being a bit nitpicky there but can be easier to read. This is a Powershell convention that you can read more about here. I am still to update this across all cmdlets...

What is the value of outputting the response as JSON (ConvertTo-Json -Depth 10)?

@DamagedDingo
Copy link
Contributor Author

DamagedDingo commented Sep 15, 2020

They are giving different outputs and as i didn't know the use-case for the other I just left it.
I only output as JSON as the get-zoomrooms was outputting as JSON so i did it to keep it in line.

Should note that i would rather get a object out (which is what i do with my local copy).

@DamagedDingo
Copy link
Contributor Author

Oh as for using list thats what it was called in the API and you obviously already had 'Get-ZoomRooms'. Feel free to rename them as you see fit.

@DamagedDingo
Copy link
Contributor Author

Added last one for today and called it Get-DashboardZoomRooms. I removed the convertto-json so now it spits out a object. Will you update the others?
Also, I have never worked on someone elses github project before so if i mess anything up just let me know.

@DamagedDingo
Copy link
Contributor Author

What happened to Get-DashboardZoomRooms?
Was it removed on purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants