Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ using in header files #60

Closed
jnohlgard opened this issue Nov 24, 2015 · 0 comments · Fixed by #63
Closed

C++ using in header files #60

jnohlgard opened this issue Nov 24, 2015 · 0 comments · Fixed by #63

Comments

@jnohlgard
Copy link

Some (most) of the header files in curlcpp have multiple using statements in the first lines of the file, this pollutes the top level namespace with standard library classes and curlcpp classes in user application files which simply want to use include curlcpp as a library and defeats the purpose of the namespace.

The solution would be to move any using statements to the innermost scope, or to remove them altogether.

See also: http://julipedia.meroh.net/2013/12/header-files-avoid-c-using-directives.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant