Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for controller-based param whitelisting (ala strong parameters) #237

Closed
wants to merge 2 commits into from
Closed

add support for controller-based param whitelisting (ala strong parameters) #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6325fcf
add support for controller-based param whitelisting (ala strong param…
rubysolo Sep 4, 2012
9aa8d3b
update whitelist check to include private methods
rubysolo Oct 14, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/inherited_resources/base_helpers.rb
View file
Open in desktop
Expand Up @@ -305,7 +305,7 @@ def resource_params

# extract attributes from params
def build_resource_params
rparams = [params[resource_request_name] || params[resource_instance_name] || {}]
rparams = [whitelisted_params || params[resource_request_name] || params[resource_instance_name] || {}]
if without_protection_given?
rparams << without_protection
else
Expand All @@ -315,6 +315,11 @@ def build_resource_params
rparams
end

def whitelisted_params
whitelist_method = :"#{ resource_request_name }_params"
respond_to?(whitelist_method, true) && self.send(whitelist_method)
end

# checking if role given
def role_given?
self.resources_configuration[:self][:role].present?
Expand Down
12 changes: 12 additions & 0 deletions test/base_test.rb
View file
Open in desktop
Expand Up @@ -18,6 +18,12 @@ def apply_scopes(object)
@scopes_applied = true
object
end

private

def user_params
(params[:user] || {}).slice(:these)
end
end

module UserTestHelper
Expand Down Expand Up @@ -195,6 +201,12 @@ def test_expose_a_newly_create_user_when_saved_with_success_and_without_protecti
@controller.class.send(:without_protection, nil)
end

def test_supports_convention_for_constructing_whitelisted_resource_params
User.expects(:new).with({'these' => 'params'}).returns(mock_user(:save => true))
post :create, :user => {:these => 'params', :those => 'params'}
assert_equal mock_user, assigns(:user)
end

def test_redirect_to_the_created_user
User.stubs(:new).returns(mock_user(:save => true))
@controller.expects(:resource_url).returns('http://test.host/')
Expand Down