Can use view note on rails 3.2.x ~ 4.x #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyuden
changed the title
Intrepidd
added a commit
that referenced
this pull request
Apr 25, 2015
Fix view note on rails 3.2.x ~ 4.x
|
Thank You ! |
|
Awesome. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View note doesn't work on rails 3.2.x ~ 4.x.
Concretely, In Rails2 the current view is stored in the controller in an instance variable named @template. But It is different in rails 3.2.x and 4.x. So, I fixed it with ActiveSupport::Notifications.
https://github.com/josevalim/rails-footnotes/pull/129/files#diff-4b7f440bebee87d9a63a043f54f49b1dL6
in addition, I added total time of view in view note.