Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionController::Streaming#send_file responses zero byte file. #68

Closed

Conversation

labocho
Copy link
Contributor

@labocho labocho commented Jan 8, 2012

When Rails.configuration.action_dispatch.x_sendfile_header is blank, ActionController::Streaming#send_file responses zero byte file.

This issue is caused by changing file position by calling "controller.response.body" in Footnotes::Filter#initialize.

@protocarl
Copy link

I've run into this issue as well and have updated the commit so it merges successfully: badcarl@a610533

@Intrepidd
Copy link
Collaborator

I still have this issue, when will it be fixed ?

@Bonias
Copy link

Bonias commented Jun 6, 2012

+1

@computeus
Copy link

+1
Fix this and include it in the gem please.

@Intrepidd
Copy link
Collaborator

i'm sorry to bother you but this issue is pretty annoying, i think i'll have to find another gem that does the same stuff but without this issue.

@nordringrayhide
Copy link
Collaborator

done. check it, pls at master branch

@computeus
Copy link

It works for me. Thank you.

@labocho
Copy link
Contributor Author

labocho commented Jul 23, 2012

Thank you for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants