Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No login validation #5

Closed
joshbetz opened this issue Mar 25, 2012 · 3 comments
Closed

No login validation #5

joshbetz opened this issue Mar 25, 2012 · 3 comments
Assignees
Labels
Milestone

Comments

@joshbetz
Copy link
Owner

Clicking "Login" takes you into the app even if no info is entered. We should probably require valid information before moving into the app.

@ghost ghost assigned erasmuss22 Mar 27, 2012
@erasmuss22
Copy link
Contributor

I've done some testing on this issue and haven't found any problems with it, but it's something to keep testing. I don't know if the Settings should save changes on viewDidDisappear. I added the same validation on that page, but the warning boxes come up when the next view loads.

@joshbetz
Copy link
Owner Author

joshbetz commented Apr 2, 2012

I thought about saving Settings on viewDidDisappear, but thought it would be easier to just rely on the AppDelegate when the app goes to the background. In makeURL you shouldn't need to pass in the login info because it's global in the app. Also, you can use getEndpoint and pass the method name to get the endpoint and then just use appendWithString to generate the rest of the URL.

@joshbetz
Copy link
Owner Author

joshbetz commented Apr 2, 2012

Nevermind. I see that you were trying to test the password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants