Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewport meta tag doesn't reflect current best use for iOS #198

Closed
e110c0 opened this issue Nov 18, 2018 · 14 comments
Closed

viewport meta tag doesn't reflect current best use for iOS #198

e110c0 opened this issue Nov 18, 2018 · 14 comments

Comments

@e110c0
Copy link

e110c0 commented Nov 18, 2018

with the iPhone X being over a year old and the iPad now having safe areas as well, changing the default viewport tag to something like 'initial-scale=1, viewport-fit=cover' would be more appropriate.

@scottaohara
Copy link
Collaborator

thanks!

@joshbuchea
Copy link
Owner

Hey gentlemen, I'm not sure that viewport-fit=cover is a good default or that removing shrink-to-fit=no is necessary. Do either of you have any references to support these changes being better defaults? I'm going to go ahead and revert for now. In the future I would prefer to discuss changes to the recommended defaults. Thanks!

@e110c0
Copy link
Author

e110c0 commented Dec 11, 2018

I did not expect that change to just be merged TBH. I'd rather start a discussion and find out what a good default is.

Adding it to the documentation of what can be done and what it is for might be the better solution.

@scottaohara
Copy link
Collaborator

yup. i jumped the gun here by not providing reasoning why i merged the change.

Upon review / testing on iOS devices running v10.3, v11.x and 12.1 shrink-to-fit is no longer recognized or needed.

I'll be posting a write up about this soon.

@scottaohara
Copy link
Collaborator

scottaohara commented Dec 11, 2018

Report: https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html which contains more testing of earlier iOS versions.

tldr; shrink-to-fit=no became irrelevant during the iOS 9.3 lifecyle and beyond.

@scottaohara scottaohara reopened this Dec 13, 2018
@scottaohara
Copy link
Collaborator

FWIW: pull request to remove shrink-to-fit from HTML5 boiler plate

@joshbuchea
Copy link
Owner

Apologies for the late response, open source has been low on my list of priorities lately. Excellent writeup @scottaohara 👌 I'm on-board, let's remove shink-to-fit=no.

@joshbuchea
Copy link
Owner

joshbuchea commented Jan 8, 2019

Also — FWIW @e110c0 I think we definitely should include viewport-fit=cover somewhere, just not sure if it belongs in the recommended minimum as it seems there are reports of it breaking websites by covering navigation and other controls in some cases.

@scottaohara
Copy link
Collaborator

no worries @joshbuchea :)

@joshbuchea
Copy link
Owner

joshbuchea commented Jan 8, 2019

@scottaohara I'm not sure how large this dataset is but, iOS 9.0-9.2.x usage is currently only @ 0.17% https://data.apteligent.com/ios/

@scottaohara
Copy link
Collaborator

scottaohara commented Jan 8, 2019

oh that's interesting. thank you @joshbuchea. going to update my article with that link. Coupled with the one I already had in the article, more data points the better. :)

@joshbuchea
Copy link
Owner

Oh yeah and almost forgot — @scottaohara thank you for doing that research and for publishing your findings 💯

@scottaohara
Copy link
Collaborator

i like to share :)

@e110c0
Copy link
Author

e110c0 commented Jan 9, 2019

@scottaohara totally agree it's not a recommended minimum.

Having all possible options in the documentation would be nice. I still haven't figured out all pitfalls of it, so not comfortable with creating a PR at the moment

jolantis added a commit to jolantis/altair that referenced this issue Jul 6, 2019
jolantis added a commit to jolantis/vanwunnik that referenced this issue Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants