Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended minimal tags #82

Closed
wants to merge 3 commits into from
Closed

Recommended minimal tags #82

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 24, 2016

I think you should add a section for the minimal websites to clarify which tags are essential. I would argue that these 5 tags are pretty much a necessity for most websites today. The first 3 especially, the last 2 being of lesser importance but still pretty critical and easy to implement. Just my recommendation.

@joshbuchea
Copy link
Owner

@olscore I think this is an excellent idea and I think others would definitely appreciate this. If you'd be willing to make a couple of small changes, I'd be happy to accept this PR. Could you:

  • Move title tag below meta tags
  • Remove the canonical link

I understand the importance of the canonical link element, but I would prefer to keep this as minimal as possible. If you're cool with my suggestions, just make the changes and I'll accept. Thanks for your contribution!

@ghost
Copy link
Author

ghost commented May 25, 2016

Cool thanks. Sorry about the extra commits, probably want consistent formatting. Feel free to close this PR if it's too cumbersome, don't really need credit. But feel free to merge if this looks good. Cheers.

@hypeJunction
Copy link

@olscore I have hijacked and squashed your PR here: #88

@hypeJunction
Copy link

hypeJunction commented May 25, 2016

To squash commits in the future:

# do this once in the repo
git remote add upstream https://github.com/joshbuche/HEAD.git
# do this for each PR your want to make
git fetch upstream
git checkout -b my-pull-request
git reset --hard upstream/master

# add your fixes

git commit -a -m 'My fixes'
# oops I did something wrong
git fetch upstream
git rebase -i upstream/master

# do your vim magic using instructions (in this case change pick to squash

# force update your origin
git push --force origin my-pull-request

Instead of upstream, you can add any existing Github fork as a remote. Don't you just love git

@ghost
Copy link
Author

ghost commented May 25, 2016

Haha I used the Github website instead of native git because I'm lazy. Thanks.

@joshbuchea
Copy link
Owner

Thanks @olscore & @hypeJunction! Appreciate the contribution.

@joshbuchea joshbuchea closed this May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants