Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another change to SGD/Momentum/Adagrad #34

Closed
joshday opened this issue Aug 1, 2015 · 0 comments
Closed

Another change to SGD/Momentum/Adagrad #34

joshday opened this issue Aug 1, 2015 · 0 comments

Comments

@joshday
Copy link
Owner

joshday commented Aug 1, 2015

I touched a lot of files here, so I wanted to make an issue of it.

I added two fields for all three types: β0::Float64 (intercept/bias term) and intercept::Bool (whether β0 needs to be updated). intercept = true by default.

This solves two things:

  • Adds an intercept without making a copy. BiasVector/Matrix is awesome, but there's no rowvec_view() method, so Adagrad(BiasMatrix(x),y) throws an error. There may be a way to fix this.
  • The intercept term will no longer be affected by the penalty (as it shouldn't).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant