Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Weighting for parametric density estimation #4

Closed
joshday opened this issue Apr 28, 2015 · 5 comments
Closed

Use Weighting for parametric density estimation #4

joshday opened this issue Apr 28, 2015 · 5 comments
Assignees
@joshday
Labels
enhancement

Comments

@joshday
Copy link
Owner

joshday commented Apr 28, 2015

Distribution estimation should have optional Weighting.
@tbreloff
Copy link
Collaborator

I think it makes sense to pass through everything to add the weighting integration. I can make a go at that, since it will help me to get familiar with everything in the repo

@joshday
Copy link
Owner Author

joshday commented Apr 28, 2015

Agreed, it's just the first class of problems I'm adding it to.

@joshday joshday self-assigned this Apr 28, 2015
@tbreloff
Copy link
Collaborator

I changed (and pushed) DEFAULT_WEIGHTING to a call to default(Weighting). It seemed cleaner. You might want to pull in those changes before adding weighting to too many more types.

@joshday
Copy link
Owner Author

joshday commented Apr 29, 2015

Okay, thanks.

@joshday
Copy link
Owner Author

joshday commented Apr 29, 2015

Current distributions implemented now use Weighting:

  • FitBernoulli
  • FitBeta
  • FitBinomial
  • FitDirichlet
  • FitExponential
  • FitGamma
  • FitMultinomial
  • FitMvNormal
  • FitNormal

@joshday joshday closed this as completed Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshday joshday

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tbreloff @joshday