Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not compatible with hugo 0.60+ #65

Closed
HeaDBanGer84 opened this issue Dec 3, 2019 · 8 comments
Closed

not compatible with hugo 0.60+ #65

HeaDBanGer84 opened this issue Dec 3, 2019 · 8 comments

Comments

@HeaDBanGer84
Copy link

because hugo change Markdown-Parser form "Blackfriday" to "Goldberg" slide seperation seems to be broken (hugo changelog)

I'm not entirely sure how you insert the section in the markdown but your method, doesn't seem to work with the new parser.

@joshed-io
Copy link
Owner

Thanks for letting us know, it looks like we'll need to change how we separate slides.

@joshed-io
Copy link
Owner

The changes to support Goldmark aren't trivial, so for now I've added instructions to the readme on how to tell Hugo to use blackfriday instead. In the future, I hope to support Goldmark, but this feels like the best path for now.

@HeaDBanGer84
Copy link
Author

Thanks for your reply. As i observed the error i looked into it and expected a bigger change. Is it still possible to use the {{< slide ...>}} shortcode for slide seperation?

@joshed-io
Copy link
Owner

Yes, you can still use that to configure slides. The shortcode goes inside the --- delimiters. See an example here: https://github.com/dzello/reveal-hugo#slide-shortcode.

@chatziko
Copy link
Contributor

chatziko commented Jan 9, 2020

with

$ hugo version
Hugo Static Site Generator v0.62.1-A1518704/extended linux/amd64 BuildDate: 2020-01-01T17:45:13Z

I don't seem to have any problem with defaultMarkdownHandler = "goldmark", am I missing something?

@joshed-io
Copy link
Owner

If you are not using the section shortcode you might be okay. But the whole list of what works vs. doesn't work is not known.

@chatziko
Copy link
Contributor

It's likely not as bad as it looks, with the changes below the exampleSite works (modulo some details, see below):

master...chatziko:hugo-0.62

Real changes:

  • fragment and section should be processed after Markdown rendering
  • [markup.goldmark.renderer] unsafe = true is needed

Weird (goldmark bug?):

  • --- fails inside code fences sometimes, not sure when

Minor incompatibility that can be worked around:

  • html tags behave weird if they are too close to other content

Not sure:

  • {{< markdown >}} doesn't work (very niche feature anyway)

@joshed-io
Copy link
Owner

@chatziko Thanks for digging into that. Good to know the delta isn't as big as I feared. Feel free to open a PR with those commits and we can track the upgrade there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants