New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runner functions #30
Comments
Assigning to @arav-agarwal2 for comment in case I'm missing something. |
When we stopped exporting the C++ functions, I was under the impression that those R functions are missing from being accessed directly. Is this not the case? |
R's got a variation of public/private objects in packages. A function that is explicitly exported is able to be called directly ( Alternatively, any object or function that isn't explicitly exported can be called at anytime using the triple colon notation, e.g. I like the idea of the package supporting two differences interfaces:
Typically the way this is done in R is for an exported function Let me think on this. |
Ok I've switched it so that exported functions call runners, which in turn use |
My understanding of the runner functions was that the call stack was, e.g.
MaxFlow(..., algorithm = "PreFlow")
->PreFlowRunner(...)
->.Call(_rlemon_PreFlowRunner, ...)
However, looking at the code, it looks like we mostly bypass the R Runner:
rlemon/R/maxflow.R
Lines 33 to 37 in dfaf03c
I'd like to keep using the R runners as a way for users to directly access the LEMON if desired, without any input checks and any other potential cleanups that we do.
The text was updated successfully, but these errors were encountered: