crypto_pwhash (argon2) support

[bufke]

What kind of work would be involved to add crypto_pwhash to this? If I'm understanding right, git master is using a up to date version of libsodium but it doesn't have any references to crypto_pwhash_*. Is it just a matter of adding the bindings? If so, do you think it's something I could help on and would you be able to point me to something on getting started? I've never worked with Java bindings to C. I'd be happy to pay for any work done by someone else if that is of interest.

[joshjdevl]

Thank you, yes it would be updating sodium.i The format is C-style syntax. Most likely can borrow from the existing definitions.

The build scripts already in the repository will invoke SWIG to take care of generating the relevant code. Only thing needed is the function definition header to be added to sodium.i. Of course adding unit tests which invoke the new method would be helpful and useful as well. Those can be added to "/src/test/java/org/libsodium/jni"

[bufke]

Started work here #71

I'd like to get some tests in. Might take some time to familiarize myself with java workflows and the project itself. I got mvn test working.

[bufke]

I got some code to generate based on sodium.i and a far too simple java test to pass that calls sodium.crypto_pwhash_bytes_min();

Should I be concerned from this in the build script? It seems to function regardless.

gcc -I../libsodium/src/libsodium/include -I${JAVA_HOME}/include -I${JAVA_HOME}/include/linux -I${JAVA_HOME}/include/darwin sodium_wrap.c -shared -fPIC -L/usr/local/lib -L/usr/lib -lsodium -o $jnilib
sodium_wrap.c:781:20: fatal error: sodium.h: No such file or directory

I happens on ./build-kaliumjni.sh inside the docker image. Once I get a better test I'll push the code.

[joshjdevl]

Yes I think that is an error in the build step. Which commands were used to run?

You can find an example of the output here

As well as in the Dockerfile

Though you should be able to just pull the built container

[bufke]

Ok the pull request is ready. It successfully runs a test with a known password + salt and computes the same hash as libsodium in other languages does. Let me know if there should be any style changes or anything else.

[pupeno]

Any ideas when this is going to be released?

[joshjdevl]

Please someone try the 1.0.7-SNAPSHOT and confirm that everything is ok?

[bufke]

1.0.7 snapshot has been working fine for me. Tested pw_hash and some cryptobox functions.

[joshjdevl]

Version 1.0.7 has been released.