Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ellipsoid self modification #17

Closed
bd-j opened this issue May 9, 2017 · 2 comments
Closed

ellipsoid self modification #17

bd-j opened this issue May 9, 2017 · 2 comments
Assignees

Comments

@bd-j
Copy link
Contributor

bd-j commented May 9, 2017

It might be cleaner to put the logic in bounding_ellipsoids for generating the ellipsods into the ellipsoids themselves (as a method). So you could supply points and pointvol to this method and the ellipsoid would update itself (instead of having to instantiate a new Ellipsoid each time)

@joshspeagle joshspeagle self-assigned this May 10, 2017
@joshspeagle
Copy link
Owner

Started working on this, and then realized that while this might be fine for a single Ellipsoid, the number of ellipsoids generated by bounding_ellipsoids (and _bounding_ellipsoids) is not fixed by design. This poses a problem for allowing internal updates in MultiEllipsoid, since we'll need to initialize new Ellipsoid objects anyways. While we could get around this with extra bookkeeping (adding ellipsoids to a list, updating them as we go, making them as "dead" when we want to ignore them, and appending new ones as we need them), I don't think this translates cleanly into self-modification.

I think I can still add in a bound method for the two classes though to allow them to be instantiated once and then be modified by users.

@bd-j
Copy link
Contributor Author

bd-j commented May 11, 2017

ok, not worth much effort if it's not easy as there's no actual new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants