Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement login page #7

Closed
Ziyang-98 opened this issue Jan 15, 2024 · 1 comment · Fixed by #79 or #80
Closed

Implement login page #7

Ziyang-98 opened this issue Jan 15, 2024 · 1 comment · Fixed by #79 or #80
Assignees
@joshtyf
Labels
feature A new feature frontend Frontend related
Milestone
M2: More features

Comments

@Ziyang-98
Copy link
Collaborator

Can do with basic form login first, then add SSO (Sign in with Google, Facebook etc) afterwards
@Ziyang-98 Ziyang-98 added frontend Frontend related feature A new feature labels Jan 15, 2024
@Ziyang-98 Ziyang-98 added this to the M1: Basic setup milestone Jan 15, 2024
@joshtyf
Copy link
Owner

joshtyf commented Jan 26, 2024

Adding more to the requirements for clarity:

Image

The login page should be simple like this. Maybe add our logo into it.

The frontend UX should conform to the following:

  1. As long as an unauthenticated user visits any page on our domain, he should be redirected to the login page
  2. SSO should be supported. Preference towards JWT as opposed to SAML.

@joshtyf joshtyf mentioned this issue Jan 26, 2024
Closed
@Ziyang-98 Ziyang-98 mentioned this issue Mar 3, 2024
Closed
@joshtyf joshtyf mentioned this issue Mar 6, 2024
Merged
@Ziyang-98 Ziyang-98 assigned joshtyf and unassigned lylaaron98 Mar 7, 2024
@joshtyf joshtyf mentioned this issue Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshtyf joshtyf

Labels
feature A new feature frontend Frontend related
Projects
None yet
Milestone
M2: More features
3 participants
@joshtyf @Ziyang-98 @lylaaron98