馃殌 Feature: Remove the manual disable of no-case-declarations #1467
Assignees
Labels
status: accepting prs
Please, send a pull request to resolve this!
type: feature
New enhancement or request
Milestone
Comments
JoshuaKGoldberg
added
type: feature
3 tasks
JoshuaKGoldberg
added a commit
that referenced
this issue
Apr 15, 2024
## PR Checklist - [x] Addresses an existing open issue: fixes #1467 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Removes the disable of the rule, and adds `{}` blocks around the two violations in the code base.
|
馃帀 This is included in version v1.59.0 馃帀 The release is available on: Cheers! 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report Checklist
mainbranch of the repository.Overview
I've had a manual disable of https://eslint.org/docs/latest/rules/no-case-declarations in this template for a while. But it doesn't really need to be there. Let's remove it to simplify the config.
Additional Info
I believe I'd added it in out of irritation for not wanting to wrap
casestatements with{}blocks. But that actually is semantically what the rule is trying to enforce, for some good reasons.The text was updated successfully, but these errors were encountered: