You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I neither get the output file generated at ../timestamps.json (which could be one expected result, given that I told it that project root was a level up), nor at project_a/timestamps.json, since that is calling dir... I get the generated output file at ../../timestamps.json, which is entirely outside the project directory itself!
In general, there seems to be a few issues if projectRootPath is passed as a relative path (e.g. ="..") instead of an absolute path by using something like __dirname, %cd%, or $PWD. I should probably improve the logic for parsing that CLI argument and determining the true absolute project root path. Even though I would suggest that users use absolute paths as input args whenever possible, this still really should be improved beyond how it currently is acting.
The text was updated successfully, but these errors were encountered:
joshuatz
changed the title
Bug: Incorrect handling of "output file" options if called from nested directory
Bug: Relate path issues / incorrect handling of "output file" options if called from nested directory
Jan 15, 2021
joshuatz
changed the title
Bug: Relate path issues / incorrect handling of "output file" options if called from nested directory
Bug: Relative path issues / incorrect handling of "output file" options if called from nested directory
Jan 15, 2021
This does not seem to be handling output file options correctly if called from a nested directory, and GDE is told the project root via CLI.
For example:
If I
cd
toproject_a
, and run something like:I neither get the output file generated at
../timestamps.json
(which could be one expected result, given that I told it that project root was a level up), nor atproject_a/timestamps.json
, since that is calling dir... I get the generated output file at../../timestamps.json
, which is entirely outside the project directory itself!In general, there seems to be a few issues if
projectRootPath
is passed as a relative path (e.g.=".."
) instead of an absolute path by using something like__dirname
,%cd%
, or$PWD
. I should probably improve the logic for parsing that CLI argument and determining the true absolute project root path. Even though I would suggest that users use absolute paths as input args whenever possible, this still really should be improved beyond how it currently is acting.The text was updated successfully, but these errors were encountered: