Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-Forge #5882] adjustOHLC() could be faster #29

Closed
joshuaulrich opened this issue Jan 31, 2015 · 1 comment
Closed

[R-Forge #5882] adjustOHLC() could be faster #29

joshuaulrich opened this issue Jan 31, 2015 · 1 comment

Comments

@joshuaulrich
Copy link
Owner

Submitted by: Joe xx
Assigned to: Nobody
R-Forge link

Downloading files from the internet takes takes a lot of time. adjustOHLC() downloads 2 files - one for dividends and another one for splits, though getSplits() already gets a file that has both splits and dividends. It would be great if you could rewrite adjustOHLC() to download only one file.

Followups:

Date: 2014-08-21 13:24
Sender: Joshua Ulrich
While you're correct, I'm not particularly interested in spending several hours of my time to code and test your idea in order to save a few seconds of computing time for each function call. A patch with tests would be most appreciated.

Date: 2014-08-21 13:24
Sender: Joshua Ulrich
Moved from Bugs to Feature Requests

@joshuaulrich
Copy link
Owner Author

Closing, since it is no longer true that getSplits() downloads a file that contains both splits and dividends, as of the change documented in #157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant