This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 155
Confirmation prompt upon exit if the servers are still in running state. #364
Labels
bug
Something isn't working
Comments
Have something similar #211 but it describes about another scenario. |
Maybe the child processes could be killed without warning, as an alternative solution. Not sure which is better |
@JayaKrishnaNamburu Thanks for reporting the issue. We're having a The killing should happen in the electron.js file. We could also check if it's possible to add a test for the process killing as mentioned in issue #344. |
Yeah @AWolf81 i think without a promt too should be fine if the servers which are running being killed 😄 |
Fixed in #367. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Confirmation popup when clicked on close if any project is already in running state.
First, I am pretty excited to see an application like this for the front end but here is a bug or maybe a un-implemented feature which I would like to see in this.
Current Behaviour
When we start a server and then click on the close window, the application closes but the server will keep on running in the background as the server is not being stopped upon exit, and next when we open the application again and start the project as we all know the project starts with the new port as the previous port is already occupied.
When I read the docs, I understood the motivation for the project is making beginner friendly which removes the use of the terminal but in this case, we need to go back and kill the process which are running in the ports.
Expected Solution
Showing a prompt upon exit by checking the status of the projects that are running, so the use manually decides on stopping the servers.
Thank you guys for the awesome work, looking ahead to start my contribution.
The text was updated successfully, but these errors were encountered: