Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

[CRA] Installing dependencies after eject #68

Closed
bennygenel opened this issue Jul 16, 2018 · 2 comments
Closed

[CRA] Installing dependencies after eject #68

bennygenel opened this issue Jul 16, 2018 · 2 comments
Labels
bug Something isn't working top priority Upcoming features of top priority
Milestone

Comments

@bennygenel
Copy link
Collaborator

After ejecting a CRA app user have to install the required dependencies before running the app again. This is leading an error in development server after ejecting the app.

It would be a good UX if a warning shows up after ejecting, telling to run command npm install or maybe event better to run the command right after eject task finishes without prompting anything.

@joshwcomeau
Copy link
Owner

Huh, I was under the impression that this wouldn't be necessary (after all, the dependencies are already there; it updates your package.json but the stuff in node_modules shouldn't change). I thought I tested this, as well... So I suspect there might be some other bug if things stop working after ejecting.

But yeah, we definitely want to make sure ejecting doesn't break things! Worth looking into. Thanks for the report 👍

@joshwcomeau joshwcomeau added the bug Something isn't working label Aug 29, 2018
@joshwcomeau joshwcomeau added this to the v0.3.0 milestone Sep 10, 2018
@joshwcomeau joshwcomeau added the top priority Upcoming features of top priority label Sep 10, 2018
@melanieseltzer
Copy link
Collaborator

Fixed in #261!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working top priority Upcoming features of top priority
Projects
None yet
Development

No branches or pull requests

3 participants