Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest: show the resulting errors in the vignette #18

Closed
richelbilderbeek opened this issue Nov 15, 2021 · 1 comment
Closed

Suggest: show the resulting errors in the vignette #18

richelbilderbeek opened this issue Nov 15, 2021 · 1 comment
Assignees

Comments

@richelbilderbeek
Copy link
Collaborator

Dear DAISIEmainland maintainer,

Thanks for DAISIEmainland and having a vignette to demonstrate what it does for a relatively simple parameter set.

Unexpectedly, in the end, when the inference error is calculated (see vignette code below) ...

```{r Calculate error}
errors <- DAISIEmainland::calc_error(
  daisie_data = island,
  ideal_ml = ideal_ml,
  empirical_ml = empirical_ml)
```

... the resulting errors are not displayed on screen, nor interpreted.

I suggest to show the resulting errors and give an intepretation. Sure, maybe the seed needs to be changed to a more interesting-yet-simple scenario :-)

@joshwlambert joshwlambert self-assigned this Nov 22, 2021
@joshwlambert
Copy link
Owner

Issue finished, will close when merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants