Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish plot_island_tbl on tree_plots branch #51

Closed
richelbilderbeek opened this issue Jan 9, 2022 · 7 comments
Closed

Finish plot_island_tbl on tree_plots branch #51

richelbilderbeek opened this issue Jan 9, 2022 · 7 comments
Assignees

Comments

@richelbilderbeek
Copy link
Collaborator

richelbilderbeek commented Jan 9, 2022

Just make the tests in test-plot_island_tbl.R produce beautiful tables.

No need to separate between ideal and empircal data yet, this depends on #55.

@richelbilderbeek richelbilderbeek self-assigned this Jan 9, 2022
@richelbilderbeek richelbilderbeek changed the title Finish plot_island_tbl Finish plot_island_tbl on tree_plots branch Jan 9, 2022
@richelbilderbeek
Copy link
Collaborator Author

Current state:

Screenshot from 2022-01-11 06-13-12

@richelbilderbeek
Copy link
Collaborator Author

Some info from Josh:

  • The col_t given to each cladogenetic species (spec_type == “C”) is the same, it is the time clade colonised
  • The branch_t of the first cladogenetic species in the clade is the same as the col_t, the branch_t of the other species in the clade is the time they branched
  • The branch_code is different from mainland_clade, species that don’t speciate have branch_code == NA.
  • A cladogenetic speciation event causes one new row to be added, unlike mainland_clade where two rows are added

@richelbilderbeek
Copy link
Collaborator Author

richelbilderbeek commented Jan 11, 2022

@joshwlambert:

  • is this picture correct? That is, the green lines should become the sketched orange lines, right?
  • Am I correct that no extinction events are present in island_tbl?

I'd enjoy to be corrected here :-)

current_state_annotated

@joshwlambert
Copy link
Owner

@richelbilderbeek the figure is correct. The two green lines should form the clade you have drawn on the left-hand side.

@richelbilderbeek
Copy link
Collaborator Author

@joshwlambert great that the figure is correct, with some luck I will finish it today.

AFAICS, I never get info on clades that went extinct before the present. Am I correct [1]?

  • [1] Whether they should be in is another question altogether. Let's talk after the next release :-)

@joshwlambert
Copy link
Owner

@richelbilderbeek the island_tbl only contains reconstructed information so no extinct species are kept.

@richelbilderbeek
Copy link
Collaborator Author

For now, this Issue is on hold until after the next release. I will close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants