Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use time before present + plot recolonisations #62

Closed
joshwlambert opened this issue Jan 18, 2022 · 7 comments
Closed

Use time before present + plot recolonisations #62

joshwlambert opened this issue Jan 18, 2022 · 7 comments
Assignees

Comments

@joshwlambert
Copy link
Owner

The Endemic_singleton_MaxAge island species are plotted near the edge of the plot but they should have the longest line. This makes me think that the plot_daisie_mainland_data function should plot "Time before present" on the x-axis. @richelbilderbeek would this be possible for you to implement?

@joshwlambert
Copy link
Owner Author

Minimal working example:

set.seed(
1,
kind = "Mersenne-Twister",
normal.kind = "Inversion",
sample.kind = "Rejection"
)

daisie_mainland_data <- DAISIEmainland::sim_island_with_mainland(
total_time = 1,
m = 100,
island_pars = c(1.0, 0.5, 10, 0.1, 0.5),
mainland_ex = 2,
mainland_sample_prob = 1,
mainland_sample_type = "complete",
replicates = 1,
verbose = FALSE
)

DAISIEmainland::plot_daisie_mainland_data(
daisie_mainland_data = daisie_mainland_data,
replicate_index = 1
)

@joshwlambert
Copy link
Owner Author

image

@joshwlambert
Copy link
Owner Author

Potentially a second bug in plot_daisie_mainland_data. In this example the ideal data should plot a recolonisation, but only plots one of the species from the all_colonisations.

set.seed(
1,
kind = "Mersenne-Twister",
normal.kind = "Inversion",
sample.kind = "Rejection"
)

daisie_mainland_data <- DAISIEmainland::sim_island_with_mainland(
total_time = 1,
m = 50,
island_pars = c(1.0, 0.5, 10, 0.1, 0.5),
mainland_ex = 2,
mainland_sample_prob = 1,
mainland_sample_type = "complete",
replicates = 1,
verbose = FALSE
)

DAISIEmainland::plot_daisie_mainland_data(
daisie_mainland_data = daisie_mainland_data,
replicate_index = 1
)

@joshwlambert
Copy link
Owner Author

image

@richelbilderbeek richelbilderbeek changed the title Bug in plot_daisie_mainland_data Use time before present + plot recolonisations Jan 19, 2022
@richelbilderbeek
Copy link
Collaborator

@joshwlambert thanks for the bug reports! I will fix this tonight.

@richelbilderbeek
Copy link
Collaborator

Moved the first part of the Isse to #64.

@richelbilderbeek
Copy link
Collaborator

Hence, this can be closed :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants