findDOMNode will be deprecated

[dsempel]

Starting from React 16.6 it is deprecated in StrictMode and it will be deprecated from React in the future. Here is some more information about this.

The docs state the following:

Normally you don’t need this because you can attach a ref directly to a DOM node.

However, reading through the source code I see that VisibilitySensor is not rendering any DOM nodes itself, so I'm not sure what would be the best way to attach the ref.

The warning in StrictMode:

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of VisibilitySensor which is inside StrictMode. Instead, add a ref directly to the element you want to reference.

[joshwnj]

Thanks for the heads up @dsempel ! Will have a think about this one

[donperi]

@joshwnj Hope the above PR works for you.

[tanyaburlakova]

@joshwnj hey!

Can you please help me, I updated my app with webpack 4 and babel 7 and react-visibility-sensor is stooped working. Do you have any idea why?

Thanks!

[dancrew32]

Hey gang, any chance this will hit master? Thanks!
RE: #142

[RoninSTi]

Any updates on #142 being merged?

[alizahir23]

hey can #142 please be merged into master if its working

[nigellima]

Hello. Any changes this PR will be merged #142? The warning is still present once the component is used

[nick-0101]

Any reasons why #142 has not been merged yet?

Issue #179 is right. This project is dead, no use waiting on something that wont be merged.

[johnbonds]

+1 on merging this please!

[nigellima]

+1 on merging this, please.

[ComradeLV]

+1 on merging, please!

[Vir-al]

+1 on merging #142, please!

[sajadko]

+1 on merging, please!

[ZengLawrence]

+1 on merging #142, please!

[slavagoreev]

Seems that this issue is stalling for ever

Temporal solution for you guys:

if (appSettings.isDevelopment) {
  const backup = console.error;

  console.error = function filterWarnings(msg) {
    const supressedWarnings = ['Learn more about using refs'];

    if (!supressedWarnings.some((entry) => msg.includes(entry))) {
      backup.apply(console, arguments);
    }
  };
}

[Seybo]

+1 on merging, please!

[myadzel]

+1 on merging #142, please!

[ThomasDEVio]

Merge it!!!

[ahmadalfy]

2023, requesting a merge

[nathggns]

Has anyone forked this project? It's not maintained anymore, so seems sensible to consider forking it to solve this particular problem.

[ahmadalfy]

Has anyone forked this project? It's not maintained anymore, so seems sensible to consider forking it to solve this particular problem.

I replaced it with react-waypoint. It's almost a drop-in replacement