Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export an errorStack #39

Closed
nc-wittj opened this issue Feb 23, 2021 · 1 comment · Fixed by #40
Closed

Export an errorStack #39

nc-wittj opened this issue Feb 23, 2021 · 1 comment · Fixed by #40

Comments

@nc-wittj
Copy link
Collaborator

When wrapping an erk error, the original err field is overwritten with the first Erk error. Promote the original err to rootErr, so the original error is not lost.
@JosiahWitt
Copy link
Owner

Instead of this, let's just export an errorStack with a list of all the wrapped errors.

@JosiahWitt JosiahWitt changed the title When wrapping an erk error, set the original err to the rootErr field Export an errorStack Feb 24, 2021
@JosiahWitt JosiahWitt mentioned this issue Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Export error stack JosiahWitt/erk
2 participants
@JosiahWitt @nc-wittj