Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo contributor username is no longer displayed, user filter doesn't work. #181

Closed
govvin opened this issue Jun 1, 2021 · 4 comments
Closed

Comments

@govvin
Copy link

govvin commented Jun 1, 2021

I'm using JOSM v17915, and the Mapillary plugin to v 2.0.0.alpha.5

In this version of the Mapillary plugin, the name of the contributor is no longer displayed on top of the Mapillary image window, nor in the Image info window. The image window states the user is "unknown user."

image

Even if I know the username of the contributor, and attempt to filter out images based on the username, the user filter doesn't work as expected, and no sequence is displayed at all.

@tsmock
Copy link
Collaborator

tsmock commented Jun 1, 2021

I don't have a call I can make to API v4 yet for users. I'm waiting for the official release of the v4 API. If there is an API to get a user from a user id (v3 tiles give me a userkey, not a user name), that will be fixed. Otherwise, it will be removed.

I haven't done either yet since I don't know what the full v4 API looks like.

@tsmock
Copy link
Collaborator

tsmock commented Jun 2, 2021

Just to avoid confusion, I've disabled the user input field and added a tooltip. Along with text in the field to make it clear that it is disabled.

@govvin
Copy link
Author

govvin commented Jun 3, 2021

Thanks @tsmock

@tsmock
Copy link
Collaborator

tsmock commented Jun 16, 2021

I'm closing this since the v4 api doesn't return any user fields, and I've removed the user filter in the v4 API code.

@tsmock tsmock closed this as completed Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants