Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to change sidekicks images when upgrading a service #22

Closed
berisberis opened this issue Jun 14, 2017 · 4 comments
Closed

Ability to change sidekicks images when upgrading a service #22

berisberis opened this issue Jun 14, 2017 · 4 comments

Comments

@berisberis
Copy link

SecondaryLaunchConfig is used in the Rancher Api for this, but i don't know more details.
@berisberis
Copy link
Author

Something similar as this from gitlabCi-rancher plugin:

cdrx/rancher-gitlab-deploy@5bf7f74?diff=split

@josmo
Copy link
Owner

josmo commented Jun 22, 2017

Sounds reasonable :) When I get a chance I'll look at it, otherwise if you want to submit a PR I'll definitely merge it in.

@Rakhmanov
Copy link
Contributor

Pull request is up: #33

@josmo
Copy link
Owner

josmo commented Feb 27, 2018

merged in. Should be in latest soon and 1.0.1

@josmo josmo closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@josmo @Rakhmanov @berisberis