Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store as .svg and convert to string #18

Closed
jossmac opened this issue Jan 14, 2016 · 2 comments
Closed

Store as .svg and convert to string #18

jossmac opened this issue Jan 14, 2016 · 2 comments

Comments

@jossmac
Copy link
Owner

jossmac commented Jan 14, 2016

Consider https://developer.mozilla.org/en-US/docs/XMLSerializer via #16

@jossmac jossmac changed the title Store SVGs as .svg and convert to string Store as .svg and convert to string Jan 14, 2016
@shmuga
Copy link
Contributor

shmuga commented Mar 16, 2016

I think best way is to use webpack like file loading.
This plugin can help you with this, but currenly you can't load custom transformation to browserify as I understand, so you need first to make react-component-gulp-tasks customizable. We can try to send pr to this module to add support of custom transformations somehow 😄

@jossmac
Copy link
Owner Author

jossmac commented May 12, 2016

@shmuga thanks for your feedback

I don't really want to lockout Browserify users. After thinking about it for a while, considering that the idea is for this package to be simple and lightweight, the addition of another module to transform SVG (which i've already done manually) seems unnecessary

Image assets should probably be themeable; I'll get back to this later

@jossmac jossmac closed this as completed May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants