Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When displaying Lightbox, warning about SVG's SMIL animations deprecated #55

Closed
neptunian opened this issue Jun 14, 2016 · 5 comments
Closed

Comments

@neptunian
Copy link
Collaborator

Click on lightbox thumbnail in the example. Read message in the console:

"SVG's SMIL animations (, , etc.) are deprecated and will be removed. Please use CSS animations or Web animations instead."

neptunian/react-photo-gallery#10

@jossmac
Copy link
Owner

jossmac commented Jun 23, 2016

This could be resolved by using something like http://elemental-ui.com/spinner

@neptunian what do you think?

@neptunian
Copy link
Collaborator Author

@jossmac Sure any kind of css animation would work. Is the loading animation the only SVG animation that needs replacing?

@jossmac
Copy link
Owner

jossmac commented Jul 2, 2016

The spinner is the only animating SVG. We could also just take it out - I'm not sure if anyone wants it?

@neptunian
Copy link
Collaborator Author

@jossmac I think it's a nice to have for those slower connections if its not causing any issues. Once preloading is implemented it my not b as necessary. Perhaps it can be optional.

@neptunian
Copy link
Collaborator Author

resolved in commit ed005d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants