-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When displaying Lightbox, warning about SVG's SMIL animations deprecated #55
Comments
This could be resolved by using something like http://elemental-ui.com/spinner @neptunian what do you think? |
@jossmac Sure any kind of css animation would work. Is the loading animation the only SVG animation that needs replacing? |
The spinner is the only animating SVG. We could also just take it out - I'm not sure if anyone wants it? |
@jossmac I think it's a nice to have for those slower connections if its not causing any issues. Once preloading is implemented it my not b as necessary. Perhaps it can be optional. |
resolved in commit ed005d8 |
Click on lightbox thumbnail in the example. Read message in the console:
"SVG's SMIL animations (, , etc.) are deprecated and will be removed. Please use CSS animations or Web animations instead."
neptunian/react-photo-gallery#10
The text was updated successfully, but these errors were encountered: