Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csharp-mode fontifies generic methods incorrectly. #84

Closed
josteink opened this issue Jun 10, 2016 · 5 comments
Closed

csharp-mode fontifies generic methods incorrectly. #84

josteink opened this issue Jun 10, 2016 · 5 comments

Comments

@josteink
Copy link
Collaborator

See this test file for an example.

This should also be submitted as a test-case.

@josteink josteink added the bug label Jun 10, 2016
josteink added a commit that referenced this issue Jun 10, 2016
These tests currently fail.

This commit illustrates #84.
@josteink
Copy link
Collaborator Author

This should be fixed before 0.9 stable, unless it gets messier than expected.

@josteink
Copy link
Collaborator Author

Doing the most obvious thing possible, I tested the sample-file with java-mode and c++-mode. Both have the same issue as csharp-mode has, while ironically plain c-mode (which shouldn't support generics/templates at all) gets the generic methods correctly.

In that regard, maybe making this a "build breaker" via ert test-cases is a bit too much?

This might be even better to get fixed upstream, and hopefully, we'll inherit the right stuff in csharp-mode for the problem to go away?

@josteink
Copy link
Collaborator Author

josteink commented Jun 13, 2016

Actually my java test-code was wrong. This is what such a declaration should look like in Java:

    public <T> T GenericMethod1(T instance)
    {

    }

And my c++-code too...

  template <typename T> T GenericMethod1(T instance)
  {

  }

And they both fontify that correctly. So we might have some work to do in csharp-mode after all.

josteink added a commit that referenced this issue Jun 15, 2016
Disable test-cases for #84
until we have a solid strategy for how to fix it.
@theothornhill
Copy link
Collaborator

This one also seems fixed in the rework branch
@josteink What do you think?

@josteink
Copy link
Collaborator Author

Agreed. You're on a freakin' roll! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants