Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor half edge mesh and tmesh to become one class #30

Open
18 tasks
jovobe opened this issue Apr 2, 2019 · 0 comments
Open
18 tasks

Refactor half edge mesh and tmesh to become one class #30

jovobe opened this issue Apr 2, 2019 · 0 comments
Assignees
Labels
editor Refers to the editor part lib Refers to the library part marker

Comments

@jovobe
Copy link
Owner

jovobe commented Apr 2, 2019

  • store knots and corners directly in half_edges
  • Ensure each face has a linked edge, which is based at a corner
    • h(f) should return a half edge, which is based at a corner. This is currently the case by coincidence and should be guaranteed.
  • Some constraints of a normal HEM are not supported. We need to check for them and fix them. The known constraints are:
    • Manifold edges
    • Fan blades
    • Fan objects
    • Orientability
    • Same vertices face in reverse order
    • Given {v0, v1, v2, v3, v4}, a face with v0–v3 already exsits, what if we want to create another face with v0–v4?
  • Rethink use of hem::get_next -> this could be removed.
  • C.5 while (g != h) -> refactor to use get edges in face.
  • zero knot intervals!
  • check for the following things:
    • rule of 5 on every type
    • const correctness
    • docs
    • are the methods implemented in a performant way?
@jovobe jovobe added lib Refers to the library part editor Refers to the editor part labels Apr 2, 2019
@jovobe jovobe self-assigned this Apr 2, 2019
@jovobe jovobe added this to Backlog in Implementation of version 1.0.0 via automation Apr 2, 2019
@jovobe jovobe moved this from Backlog to To do in Implementation of version 1.0.0 Apr 2, 2019
@jovobe jovobe moved this from To do to In progress in Implementation of version 1.0.0 May 13, 2019
@jovobe jovobe closed this as completed Jul 10, 2019
Implementation of version 1.0.0 automation moved this from In progress to Done Jul 10, 2019
@jovobe jovobe added the marker label Jul 10, 2019
@jovobe jovobe reopened this Jul 10, 2019
Implementation of version 1.0.0 automation moved this from Done to To do Jul 10, 2019
@jovobe jovobe moved this from To do to Backlog in Implementation of version 1.0.0 Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Refers to the editor part lib Refers to the library part marker
Projects
Development

No branches or pull requests

1 participant