Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to consul ~0.7.0 #248

Merged
merged 2 commits into from Nov 21, 2016
Merged

upgrade to consul ~0.7.0 #248

merged 2 commits into from Nov 21, 2016

Conversation

flyinprogrammer
Copy link
Contributor

I'm running the tests locally right now, but let's see if this works in automation too?

@tgross
Copy link
Contributor

tgross commented Nov 18, 2016

LGTM. Can we rebase this on master so that we can run thru the integration tests again with the updated Consul container?

@flyinprogrammer
Copy link
Contributor Author

yup - brb!

@flyinprogrammer
Copy link
Contributor Author

interesting running this locally results in all kinds of intermittent failures, I'll have to dig into what these integration tests do/are and see if a pattern and solution emerges 😀

@flyinprogrammer
Copy link
Contributor Author

flyinprogrammer commented Nov 19, 2016

I suspect this will pass; however, my wait4consul pattern is probably unacceptable. I can refactor this functionality into test_probe, and use the established pattern for accomplishing this goal.

@tgross
Copy link
Contributor

tgross commented Nov 21, 2016

I suspect this will pass; however, my wait4consul pattern is probably unacceptable. I can refactor this functionality into test_probe, and use the established pattern for accomplishing this goal.

Is the problem just that we're using the -dev server now instead of doing a bootstrap=true / bootstrap-expect=1?

@flyinprogrammer
Copy link
Contributor Author

no the problem is consul is just slower to boot up now, and we never had explicit waits in place.

@tgross
Copy link
Contributor

tgross commented Nov 21, 2016

Ok, LGTM.

@tgross tgross merged commit d93c156 into TritonDataCenter:master Nov 21, 2016
@tgross
Copy link
Contributor

tgross commented Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants