This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
Allow repeatable calls to 'make install'. #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if 'make install' is invoked multiple times it fails due to it trying to recreate the 'libhttp_parser.so' symlink. This commit adds the '-f' flag to the 'ln' invocations, which results in the 'libhttp_parser.so' symlink pointing to the newly installed shared library.
|
@indutny ... thoughts? |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
make installis invoked multiple times it fails due to it trying to recreate thelibhttp_parser.sosymlink.Adding the
-fflag to thelninvocations fixes this, but will change the default http-parser used to the newly installed version if there are multiple versions installed. I think this is what we want to do anyway since we are clobbering any existinghttp-parser.hduring install, so not repointing the symlink would result in a mismatch between the default library and header versions.The alternative would be to version
http-parser.hand add a symlink for it, while trying to ensure we always update both symlinks atomically.