Fix building error on Cygwin

[jiefoxi]

Error when building on Cygwin

$ make
cc -I. -DHTTP_PARSER_STRICT=1 -DHTTP_PARSER_DEBUG=1  -Wall -Wextra -Werror -O0 -g  -c http_parser.c -o http_parser_g.o
cc1: warnings being treated as errors
http_parser.c: In function ‘parse_url_char’:
http_parser.c:415:3: error: array subscript has type ‘char’
Makefile:26: recipe for target `http_parser_g.o' failed
make: *** [http_parser_g.o] Error 1

[bnoordhuis]

Thanks, I'll merge your patch if you can sign the CLA. You should probably report this error to the cygwin maintainers, it looks like a bug in the implementation of isspace().

[jiefoxi]

Sorry, I won't sign it cause it requires too much personal information to provide. :)

[bnoordhuis]

Okay, no problem.

[janl]

This is sad. A one line patch does not require a CLA.

[ckruse]

I hope this is a joke?

[bnoordhuis]

This is sad. A one line patch does not require a CLA.

Where do you draw the line? A two-line patch? Three? Ten? Better to be strict and consistent.

[trodrigues]

Can't he just declare it's in the public domain and the joyent guys can merge it? I think I remember dojo guys saying they could do that.

[Seldaek]

@bnoordhuis a type cast isn't even a line, it's not code, it's nothing. It's not like the CLA is of much use anyway, but when it blocks such PRs it's really getting absurd.