OS-8136 Add DISCARD/TRIM support to bhyve (illumos specific bits) #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgerdts
reviewed
Mar 19, 2020
| @@ -630,6 +650,10 @@ blockif_open(const char *optstr, const char *ident) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if (nodelete == 0 && ioctl(fd, DKIOC_CANFREE, &candelete)) | |||
There was a problem hiding this comment.
ioctl() does not return a bool or boolean_t, so its return value should be compared to 0 or -1.
There was a problem hiding this comment.
The extant freebsd code uses this style, so I opted for consistency with it (though I agree that being explicit would be better). We don't upstream the stuff in #ifndef __FreeBSD__ blocks AFAIK, so there's no upstream issue though that would cause conflicts there, so I don't feel too strongly either way.
There was a problem hiding this comment.
I guess this isn't the only place where I hold my nose in the bhyve code.
mgerdts
previously approved these changes
Mar 19, 2020
| @@ -630,6 +650,10 @@ blockif_open(const char *optstr, const char *ident) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if (nodelete == 0 && ioctl(fd, DKIOC_CANFREE, &candelete)) | |||
There was a problem hiding this comment.
I guess this isn't the only place where I hold my nose in the bhyve code.
jasonbking
changed the title
papertigers
reviewed
Mar 20, 2020
papertigers
previously approved these changes
Mar 20, 2020
papertigers
approved these changes
Mar 20, 2020
mgerdts
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.