Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-8136 Add DISCARD/TRIM support to bhyve (fix compiler warning) #274

Merged
merged 3 commits into from
Mar 24, 2020
Merged

OS-8136 Add DISCARD/TRIM support to bhyve (fix compiler warning) #274

merged 3 commits into from
Mar 24, 2020

Conversation

jasonbking
Copy link

This fixes the gcc4 compiler warnings (but still compiles fine with gcc7)

@jasonbking
Copy link
Author

Comparing the existing in-gate bhyve w/ the build fix shows no diffs:

--- 1   2020-03-24 06:25:22.426452662 +0000
+++ 2   2020-03-24 06:25:32.413965133 +0000
@@ -1,4 +1,4 @@
-disassembly for /usr/sbin/bhyve
+disassembly for bhyve

 blockif_proc()
     blockif_proc:       55                 pushq  %rbp

@jasonbking jasonbking merged commit 8ea6e1e into master Mar 24, 2020
@jasonbking jasonbking deleted the OS-8136 branch March 24, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgerdts mgerdts mgerdts approved these changes

Assignees
No one assigned
Labels
integration-approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasonbking @mgerdts